Thread (4 messages) flat view 4 messages, 3 authors, 2007-05-05

Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support

From: Vitaly Bordug <hidden>
Date: 2007-05-05 23:28:26
Also in: lkml

On Fri, 4 May 2007 12:35:43 -0700
Andrew Morton wrote:
On Fri, 04 May 2007 03:57:51 +0400
Vitaly Bordug [off-list ref] wrote:
quoted
Adds support for PowerQuicc on-chip PCMCIA. The driver is
implemented as of_device, so only arch/powerpc stuff is capable to
use it, which now implies only mpc885ads reference board.

To cope with the code that should be hooked inside driver, but is
really board specific (like set_voltage), global structure
mpc8xx_pcmcia_ops holds necessary function pointers that are filled
in the BSP code.
argh.

akpm:/home/akpm> grep '^.*        ' x | wc -l 
72

please, Linux uses hard-tabs, not
spacespacespacespacespacespacespacespace everywhere.
Whoops. That must've survived being copypasted from the original m8xx_pcmcia.c.
That reminds me to do Lindent on the affected sources but that is subject for another patch.
Sorry for the hassle. 

Apparently all the issues were correct, and I'll follow-up with the reworked patch. Thanks for looking at it.

-- 
Sincerely, Vitaly
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help