Re: [PATCH 2/2] powerpc: change topology_init() to a subsys_initcall

Hi Michael,

On Wed May 2 2007 8:11 pm, Michael Ellerman wrote:

On Wed, 2007-05-02 at 12:11 -0500, Kevin Corry wrote:

quoted

Change the powerpc version of topology_init() from an __initcall to
a subsys_initcall to match all other architectures.

Signed-off-by: Kevin Corry <redacted>

Index: linux-2.6.21/arch/powerpc/kernel/sysfs.c
===================================================================

--- linux-2.6.21.orig/arch/powerpc/kernel/sysfs.c
+++ linux-2.6.21/arch/powerpc/kernel/sysfs.c

@@ -498,4 +498,4 @@ static int __init topology_init(void)

 	return 0;
 }
-__initcall(topology_init);
+subsys_initcall(topology_init);

topology_init() depends on the register_one_node() stuff being
available, which relies on register_node_type() being called AFAICT -
which is a postcore_initcall(). So that's OK.

It also creates sysfs files, which is OK because long before initcalls
run vfs_caches_init() called mnt_init() which called sysfs_init().

Just to be super safe it'd be good to diff your sysfs before and after
the change. But assuming that show's nothing this looks fine to me.

I booted with and without this patch applied, and the file listings of /sys on 
both kernels show no differences (other than timestamps).

Thanks for the feedback.
-- 
Kevin Corry
kevcorry@us.ibm.com
http://www.ibm.com/linux/