On Wed, May 30, 2007 at 10:21:22AM -0500, Scott Wood wrote:

David Gibson wrote:

quoted

On Wed, May 30, 2007 at 10:09:11AM -0500, Scott Wood wrote:

quoted

Is there any particular reason to not just do a direct call to 
cuboot_init, and move the memcpy and end-of-ram calculation there?  I'd 
rather avoid macros if possible.

Uh.. yeah.. because cuboot_init() doesn't know the size to memcpy(),
because it doesn't have the right bd_t definition.

Ah, yes.  Don't mind me, it's still morning here... :-P

We could probably do away with the copy altogether, though, as u-boot 
puts the bd_t near the stack, which is exempted from the bootwrapper's 
heap with the 1MiB exclusion.

Possibly, though the copy is safer.  I'm hoping to be able to merge
libfdt in a few weeks, which with luck will let me get rid of malloc()
entirely.  I'll think about revisiting this then.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson