Thread (28 messages) 28 messages, 4 authors, 2007-05-28

Re: [PATCH 1/13] powerpc: Add Makefile rules to wrap dts file in zImage

From: David Gibson <hidden>
Date: 2007-05-25 01:32:42

On Thu, May 24, 2007 at 02:28:32PM -0700, Mark A. Greer wrote:
On Tue, May 22, 2007 at 10:23:49AM +1000, David Gibson wrote:
quoted
On Mon, May 21, 2007 at 11:10:43AM -0700, Mark A. Greer wrote:
quoted
On Mon, May 14, 2007 at 10:33:32AM +1000, David Gibson wrote:
quoted
On Fri, May 11, 2007 at 05:53:36PM -0700, Mark A. Greer wrote:
quoted
+$(obj)/zImage.dts:	$(addprefix $(obj)/, $(dts-y))
+	@rm -f $@; ln $< $@
+$(obj)/zImage.dts_initrd:	$(addprefix $(obj)/, $(dts_initrd-y))
+	@rm -f $@; ln $< $@
+
I thought you said you were going to drop this bit?
Hi David.

Would you elaborate on what your alternative is?  A lot of the Makefile
stuff is still black magic to me.
Just leave them out.  As long as you add the correct specific
zImage.dts.% and zImage.dts_initrd.% targets to image-y and initrd-y,
then a "make zImage" from the top-level Makefile will get them built.
That defeats the whole purpose of the patch--to allow the selection of
wrapping a dtb or not at build time.  Its just like initrd, you choose
whether to "do it" at build time.
Ah, right.  Remind me why that's useful again?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help