Re: 440 ebony patch seems to have broken 85xx build on powerpc.git

On Thu, 2007-05-24 at 21:05 +0200, Segher Boessenkool wrote:

quoted

$(obj)/44x.o: BOOTCFLAGS += -Wa,-mbooke
$(obj)/ebony.o: BOOTCFLAGS += -Wa,-mbooke

Probably -Wa,-m440 works better.  However...

quoted

  /opt/montavista/cge/devkit/ppc/85xx/bin/ppc_85xx-gcc -m32
-Wp,-MD,arch/powerpc/boot/.ebony.o.d -Wall -Wstrict-prototypes -O2
-fomit-frame-pointer -fno-builtin -nostdinc -isystem
/opt/montavista/cge/devkit/ppc/85xx/bin/../lib/gcc/powerpc-montavista- 
linux-gnuspe/4.2.0/include
-fPIC -fno-stack-protector -Iarch/powerpc/boot
-I/home/djiang/community/git-repos/tmp/ppc-master/arch/powerpc/boot  
-Wa,-mbooke
-c -o arch/powerpc/boot/ebony.o arch/powerpc/boot/ebony.c

Nothing is telling GCC what CPU to compile for, so it
will just use the compiler's default, which very likely
is not what you want.  For files that will only ever
be used on 440, the correct flags are -mcpu=440 -Wa,-m440 .

We could add that to the per-file flags already, right?

josh