Re: [PATCH] pseries: asm/pci-bridge.h CONFIG_ minor cleanup

On Tue, May 22, 2007 at 10:40:59AM +1000, Michael Ellerman wrote:

On Mon, 2007-05-21 at 18:18 -0500, Linas Vepstas wrote:

quoted

Use the correct CONFIG_ option to mark off the EEH bits.

You're making the struct 4 bytes larger by creating a hole here :(

Hmm. Perhaps I could shuffle one of the ints down ...  

I figured there might be some vague cache-line benefits to
getting the eeh stuff out of the way. 

quoted

 	u32	config_space[16];	/* saved PCI config space */
+#endif

It looks correct, but I think it's worth mentioning in the changelog
that config_space was previously unconditionally defined, but is now
within CONFIG_EEH.

I could just tell that someone would remark on this; why I didn't
mention it, I don't know.

--linas