Re: [PATCH] ibm_emac: Correctly detect old link speed

On Wed, May 16, 2007 at 08:44:47PM +0200, Stefan Roese wrote:

On Wednesday 16 May 2007, Eugene Surovegin wrote:

quoted

On Wed, May 16, 2007 at 01:00:08PM +0200, Stefan Roese wrote:

quoted

This patch fixes a bug where the link speed change was not
detected correctly. This occured on a 440SPe (EMAC4) system
where the old link speed was 100Mbps and the new link speed
is 1000Mbps.

Good catch, Stefan. Unfortunately, I have to NACK your patch - you
broke non EMAC4 builds.

Yes, you're right of course.

quoted

Correct fix is just to remove EMAC_MR1_MF_1000GPCS from the first
if condition.

Yep.

quoted

I'll send correct fix shortly along with other queued patches.

Thanks.

I've merged essentially the same fix into the device tree aware
"new_emac" driver.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson