Thread (5 messages) flat view 5 messages, 2 authors, 2007-05-21

Re: New version of the device tree aware EMAC driver

From: Valentine Barshak <hidden>
Date: 2007-05-16 16:19:42

David Gibson wrote:
I've made a few more tiny tweaks to BenH's rewritten device-tree based
4xx EMAC driver.  The main change is that it now no longer requires
'device_type', just 'compatible' to be set in the ZMII and MAL device
nodes when probing.  This works better with current thinking on
flattened device trees which discourages creating new device_type
values unless there is a clear use for a new device class binding.

The patch can be obtained from:

http://ozlabs.org/~dgibson/home/emac/powerpc-emac-new-20070516.patch

  
Looks like EMAC_FTR_STACR_OC_INVERT is missed in the EMAC_FTRS_POSSIBLE
(ibm_newemac/core.h)

Should be something like this:
    EMAC_FTRS_POSSIBLE    =
#ifdef CONFIG_IBM_NEW_EMAC_EMAC4
        EMAC_FTR_EMAC4 | EMAC_FTR_HAS_AXON_STACR | 
EMAC_FTR_STACR_OC_INVERT |
#endif
Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help