Re: Fixed PHY and MPC832x based boards don't work

On Mon, 2007-05-14 at 00:25 +0200, Joakim Tjernlund wrote:

On Mon, 2007-05-14 at 00:36 +0400, Vitaly Bordug wrote:

quoted

On Sun, 13 May 2007 16:39:30 +0200
Joakim Tjernlund wrote:

quoted

Trying to make the Fixed PHY work under my 832x based board on current
linus tree without success. Earlier kernels with custom PHY code for
ucc_geth work without any special tricks.

If I enable the FIXED_MII_100_FDX option I get:
ls bus/mdio_bus/devices/
fixed@100:1@ 

but ucc_geth wants its PHYs under 
ls -l bus/of_platform/devices/*phy*
lrwxrwxrwx    1 root     root            0 May 12 17:32
bus/of_platform/devices/ethernet-p hy.1
-> ../../../devices/e0100000.qe/e0102320.mdio/ethernet-phy.1/
lrwxrwxrwx    1 root     root            0 May 12 17:32
bus/of_platform/devices/ethernet-p hy.3
-> ../../../devices/e0100000.qe/e0102320.mdio/ethernet-phy.3/
lrwxrwxrwx    1 root     root            0 May 12 17:32
bus/of_platform/devices/fixed-phy. 2
-> ../../../devices/e0100000.qe/e0102320.mdio/fixed-phy.2/ These are
3 PHYs I just added in the DTS tree:

		mdio@2320 {
			#address-cells = <1>;
			#size-cells = <0>;
			reg = <2320 18>;
			device_type = "mdio";
			compatible = "ucc_geth_phy";

			phy1: ethernet-phy@18 {
				linux,phandle = <212000>;
				reg = <18>; // 24
				device_type = "ethernet-phy";
				interface = <3>; //ENET_100_MII
			};
			phy2: fixed-phy@64 {
				linux,phandle = <212001>;
				reg = <d#100>;
				device_type = "ethernet-phy";
			};
			phy3: ethernet-phy@19 {
				linux,phandle = <212002>;
				interrupt-parent = <700>;
				interrupts = <12 2>;
				reg = <19>; // 25
				device_type = "ethernet-phy";
				interface = <3>; //ENET_100_MII
			};
		};

How do I add a fixed PHY so that ucc_geth finds it?

well I guess ucc stuff follows gianfar trend in mdio bus specification for the phy.
So, it would look like %d:%d or something like that.

Can you please dump the whole dts here?

Sure, it look pretty much like the 832x_mds
phy2 is my experiment to get hold of the fixed phy, but the others should also be converted into a fixed phy. Here goes my DTS:

Ping, any ideas how to make fixed PHY work? 
This is a regression(sort of) compared with 2.6.20. The old PHY impl.
for ucc_geth did accept these PHYs, the Gen PHY driver would just report
a PHY id of ffffffff and move on.

 Jocke

[SNIP DTS]