Thread (10 messages) flat view 10 messages, 5 authors, 2007-05-13

Re: [PATCH] pasemi: electra IDE/pata_platform glue

From: Alan Cox <hidden>
Date: 2007-05-13 13:35:10
Also in: linux-ide

quoted
Easier to use pata_platform I would think ? Just create the OF device and
bind it to pata_platform.
Not sure I understand what you mean. pata_platform expects a platform_device,
which cannot be cast from an of_device.
Other than the binding and wanting to use the standard ->set_mode they
appear to be identical so a copy of pata_platform ought to turn into a
pata_of very nicely.
Olof, have you looked at which of the two ->set_mode functions is more
appropriate for electra? I would guess that you actually want to use
the ata_generic one.
You almost certainly simply don't want to provide one. I'm not sure the
pata_platform default one is right at all as it will assume the firmware
tuned everything. ata_generic does this purely because it is a "last
resort" driver for chips we can't tune/program at all.

Alan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help