Re: [PATCH v3] 83xx USB platform code rework

quoted

+		} else if (prop && !strcmp(prop, "serial")) {
+			if (!strcmp(of_get_property(np, "dr_mode", NULL), "otg")) {

                                    
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Is there any chance that np doesn't have a "dr_mode" property?

Yes, of course -- you can never trust the incoming
device tree to be "correct".

Also, please no underscores in property names.


Segher