Thread (39 messages) 39 messages, 11 authors, 2007-05-16

Re: arch/powerpc/sysdev: dumping ground or only for shared drivers?

From: Linas Vepstas <hidden>
Date: 2007-05-11 17:05:13

On Fri, May 11, 2007 at 10:26:27AM +1000, Paul Mackerras wrote:
Olof Johansson writes:
quoted
This adds yet another set of chipset drivers under sysdev, that are
only used by one platform (several board ports under that platform,
but only one platforms/* directory).

In my opinion, they really should go under the platform directory instead,
and not clutter the shared directory.
I disagree, actually.  Having these things in a shared directory makes
it more likely that people will look at the code.  That means that
it's more likely that bugs will be found, and more likely that parts
of the code can get reused when people are doing the port to a new
chip or board.

If there were hundreds of files in arch/powerpc/sysdev then I would be
more likely to agree with you, but there aren't.
I like Paul's take, it matches my gut instincts.

--linas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help