Re: [PATCH] Mark prop unused in early_init_dt_scan_chosen().

On Wed, May 09, 2007 at 09:56:34AM +1000, Michael Ellerman wrote:

On Tue, 2007-05-08 at 12:14 -0500, Scott Wood wrote:

quoted

The prop variable is only referenced when initrd support is
turned on.

Signed-off-by: Scott Wood <redacted>
---
 arch/powerpc/kernel/prom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index caef555..6705459 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c

@@ -720,7 +720,7 @@ static int __init early_init_dt_scan_chosen(unsigned long node,
 					    const char *uname, int depth, void *data)
 {
 	unsigned long *lprop;
-	u32 *prop;
+	u32 __attribute__((unused)) *prop;
 	unsigned long l;
 	char *p;

Hi Scott,

Let's be honest, this is a hack. I think it'd be cleaner to pull the
initrd logic out into a separate function.

More speficially, if the variable ever really becomes unused, this
will continue to suppress the warning.  I'd be happied with an #ifdef
initrd around it, ugly though that is.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson