Re: [PATCH] 86xx: Enable the AC97 interface on 8641D board.

On Thu, May 03, 2007 at 10:55:25AM -0500, Jon Loeliger wrote:

On Thu, 2007-05-03 at 09:44, Kumar Gala wrote:

quoted

On May 2, 2007, at 4:53 PM, Jon Loeliger wrote:

quoted

From: Jason Jin <redacted>

HD interface and AC97 interface share some pins and they are  
enabled at
the same time, In order to use AC97 interface, we need to disable  
the HD
interface first.

Signed-off-by:Jason Jin[off-list ref]
Acked-by: Jon Loeliger <redacted>
---
 arch/powerpc/platforms/86xx/mpc86xx_hpcn.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

Is the HD feature not used at all?  Is there a AC97 Driver CONFIG_  
that makes sense to wrap that with?  Just wondering about the mutual  
exclusion (and how to provide flexibility to the user).

- k

The ULI supports both the HD and AC97 interfaces, but the 8641
only supports the AC97 interface.  Thus we can straight disable
the HD and convert/configure the shared pins to be AC97.  Thus,
there is no real CONFIG_ need at all.  It's only AC97.  And then
ultimately, the presence of sound support is controlled by
the ALSA config options as per normal.

This sounds like something that firmware should take care of, not
hardcoded in the board code.  Seems like the device is just a PCI device
that doesn't have a device tree entry.

Why not do this in u-boot instead?


-Olof