Thread (21 messages) 21 messages, 4 authors, 2007-05-01

Re: [PATCH 2/5] [PPC] Merge common virtex header files

From: Grant Likely <hidden>
Date: 2007-04-27 18:49:29

On 4/25/07, Peter Korsgaard [off-list ref] wrote:
quoted
quoted
quoted
quoted
quoted
"GL" == Grant Likely [off-list ref] writes:
GL> -#if defined(CONFIG_XILINX_ML300)
GL> -#include <platforms/4xx/xilinx_ml300.h>
GL> -#endif
GL> -
GL> -#if defined(CONFIG_XILINX_ML403)
GL> -#include <platforms/4xx/xilinx_ml403.h>
GL> +#if defined(CONFIG_XILINX_VIRTEX)
GL> +#include <platforms/4xx/virtex.h>
GL>  #endif

Could we make that

#if defined(CONFIG_XILINX_ML300) || defined(CONFIG_XILINX_ML403)

instead? I'm using RedBoot on a virtex platform, and hence another
struct bd_info than the ML300/ML403.
Alternate suggestion: Can we change virtex support to use the
structure defined in ppcboot.h instead?  (I've actually got that
change in my tree and was planning on posting it for review today or
tomorrow).  bd_t is a stinking ugly mess, but things would be better
if we standardize all virtex platforms on the stinking ugly mess
shared by almost all the other ppc embedded board ports.

Cheers,
g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help