Thread (29 messages) 29 messages, 9 authors, 2007-04-29

Re: [PATCH v2] [2.6.22] pasemi: cpufreq driver

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2007-04-26 10:22:59

On Thu, 2007-04-26 at 00:37 -0500, Olof Johansson wrote:
+       policy->cur = pas_freqs[cur_astate].frequency;
+       policy->cpus = cpu_possible_map; 
That doesn't seem right.

Either, all your processors scale along each other in which case you
should use cpu_online_map here, or they scale each on their own in which
case you just set a single bit here.

The generic code works like this:
CPU 0 is brought online and cpufreq initialised for it
CPU 1 is brought online and cpufreq initialised for it. if cpus includes
more than a single bit, cpufreq is linked to the first other CPU in
policy->cpus and then cpufreq for CPU1 is deinitialised again.

We have the same bug on powermac but for some reason the patch to fix it
that I posted a long time ago (look for "powermac: fix G5-cpufreq for
cpu on/offline") wasn't applied yet. Look at it though, it includes a
comment on what needs to be done.

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help