Re: RFC: powerpc: Start splitting up mmu.h by MMU type

On Apr 19, 2007, at 7:56 PM, David Gibson wrote:

On Thu, Apr 19, 2007 at 07:11:07AM -0500, Kumar Gala wrote:

quoted

On Apr 19, 2007, at 1:54 AM, David Gibson wrote:

quoted

This patch makes a start to sorting out the tangled mess of MMU
related header files in asm-powerpc, and weaning arch/powerpc off  
the
remaining asm-ppc headers it uses.

Specifically it splits the ppc64 specific (or more strictly, the
64-bit hash table specific) parts of asm-powerpc/mmu.h into its own
file, asm-powerpc/mmu-hash64/mmu.h.  Similarly, PowerPC 44x
definitions are taken from asm-ppc/mmu.h, trimmed down for use in
arch/powerpc and place in their own file, asm-powerpc/mmu-44x/mmu.h.

mmu.h definitions for other 32-bit MMU types remain in asm-ppc/mmu.h
for now, but should be likewise split into their own files.

I asked this before, but why the need for a separate directory per
mmu type?  why not just include/asm-powerpc/mmu-44x.h?

Because I have further patches in the works that add MMU specific
versions of tlbflush.h, pgtable.h and so forth to the same
directories.

Well I agree pgtable.h getting split wouldn't be a bad idea.  But  
tlbflush.h is only 146 lines, splitting it doesn't seem worth the  
trouble.  So having a mmu-44x, mmu-hash32, mmu-hash64, mmu-8xx, mmu- 
fsl_booke, mmu-40x for just two files seems a bit much.

I'm not wedded to the idea, but it seemed like a reasonable way to
organize things.

- k