Thread (109 messages) 109 messages, 10 authors, 2007-04-27

Re: [PATCH 6/6] [POWERPC] make struct property's value a void *

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-04-05 23:02:06

It would remove the millions of casts (and the need for the GCC
-fstrict-aliasing flag for this code).
Ugh ? We don't need casts with void *, that's the whole point ... while
we would do if we used char * ...

I'm not familiar with the details of the strict-breaking-good-programs
rules also known as strict-aliasing but isn't void * supposed to alias
all ? if not, that's really stupid... But even then, I fail to see how
this would break an aliasing rule as we aren't accessing the same object
from two different types and we aren't even writing to it.
I agree.  However when making this code more generally useful,
it would be good to make it more correct at the same time, since
it will only get harder to do so later on.
I think it's perfectly correct with void * ...

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help