Re: [Cbe-oss-dev] [PATCH] Ignore memory listed in PS3 device tree
From: Michael Ellerman <hidden>
Date: 2007-04-03 02:42:13
Attachments
- signature.asc [application/pgp-signature] 189 bytes
From: Michael Ellerman <hidden>
Date: 2007-04-03 02:42:13
On Mon, 2007-04-02 at 19:36 +0200, Segher Boessenkool wrote:
quoted
quoted
quoted
The old 2.6.16 kernel handled memory statically and it was shown in the device tree. The current kernel deals with the hypervisor and hotplugs the memory, so we should just ignore anything that's reported in the device-tree. This enables the current kernel to be booted from 2.6.16 without evil hacks in head_64.S to override the device-tree.Surely when you are booted you already have some memory plugged for you -- shouldn't that memory be in the device tree?See ps3_mm_init(), called from _probe_.Yes sure, the hypervisor has given you some memory already, and it tells you about it.
My point was it's not coming out of the device tree, it's just manually lmb_add'ed.
My question remains: shouldn't Linux get that information from the device tree, instead? The bootwrapper or bootloader can put it there.
Yes it _should_, but it doesn't. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person