Thread (29 messages) 29 messages, 8 authors, 2007-04-10

Re: [patch 07/10] Page fault handler should not depend on CONFIG_KPROBES

From: Anton Blanchard <hidden>
Date: 2007-03-23 14:19:45

 
NACK until the performace implication a fixed.  Martin measured this
costs 300 cycles on s390 even without any notifier activce, and while
ppc might be slightly bad that's still too much to add to the pagefault
handler unconditionally.  Please add a light weight method to check
whether there is any activce user of the notifications.  Also please
move the code into kernel/ at the same time instead of having the exact
same thing duplicated all over, as in my notify_die patches.
Im struggling to understand how they could take 300 cycles to execute
this code sequence. We have seen similar questions on the ia64 side,
they both must have some pretty fundamental branch prediction issues.

I measured this in sim and the sequence takes under 20 cycles on a
power5 class machine, and thats a pessimistic estimate.

Anton
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help