Thread (13 messages) 13 messages, 4 authors, 2007-03-23

Re: [PATCH 4/10] Add arch/powerpc driver for UIC, PPC4xx interrupt controller

From: David Gibson <hidden>
Date: 2007-03-23 03:28:58

On Thu, Mar 22, 2007 at 10:51:18AM +0100, Domen Puncer wrote:
On 22/03/07 20:22 +1100, David Gibson wrote:
quoted
+static int uic_set_irq_type(unsigned int virq, unsigned int flow_type)
quoted
+	case IRQ_TYPE_LEVEL_HIGH:
+		trigger = 0; polarity = 1;
+		break;
+	case IRQ_TYPE_LEVEL_LOW:
+		trigger = 0; polarity = 1;
Is this intended to be the same?
Oops, no.  Thanks for spotting that, the Ebony has no level-low
devices, so I didn't notice any problems.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help