Re: [PATCH][POWERPC] QE: Make QUICC Engine support a configurableoption

On Thu, Mar 15, 2007 at 10:07:31AM -0500, Kumar Gala wrote:

 config MPC836x_MDS
 	bool "Freescale MPC836x MDS"
 	select DEFAULT_UIMAGE
-	select QUICC_ENGINE
 	help
 	  This option enables support for the MPC836x MDS Processor Board.

 endchoice

+config QUICC_ENGINE_83xx
+	bool "QUICC Engine Support"
+	select QUICC_ENGINE
+	depends on PPC_MPC836x || PPC_MPC832x
+	default y
+	---help---
+	  The QUICC Engine (QE) is a new generation of communications
+	  coprocessors on Freescale embedded CPUs (akin to CPM in older chips).
+	  Selecting this option means that you wish to build a kernel
+	  for a machine with a QE coprocessor.
+

Instead of doing it like this, what about having each QE-enabled SOC
select HAS_QUICC_ENGINE, and then have the user-configurable
QUICC_ENGINE option depend on HAS_QUICC_ENGINE?

That way, there's no need for separate 83xx and 85xx defines, and the
knowledge of which SOCs have QE is maintaned with the SOC entry, rather
than in a separate list.

-Scott