RE: [PATCH] Add irq host and hwirq pair fields to outputwhenshowing interrupts.
From: Zhang Wei-r63237 <hidden>
Date: 2007-03-15 09:53:35
quoted
quoted
Now, regarding the patch itself, printing the hw irq is not=20 that useful without some indication of which host it belongs to. Best=20is to add aquoted
quoted
name() or something like that to the host ops. =20=20 Sure, can I use the PIC controller node full name from=20of_tree as thequoted
host name?=20 There is no 1:1 relationship between an OF node and an irq=20 host. (There is -most- of the time but I left the irq core on purpose more=20 flexible, hence the match() method. On some setups it makes sense to=20 have multiple HW PICs share a single domain number (for example on cell). =20 Thus I'd rather have a way for the host to give you that=20 name, which in turn can be the OF path if there is such a thing, or something else... =20 Best might be 4 columns: =20 <virq> <hwirq> <pic name> <host name> =20 (PIC name is the same as in /proc/interrupts). =20quoted
Do you prefer debugfs instead of /proc/interrupts?=20 Yes, at least for now. Maybe if we can convince ourselves that nothing significant would break of changing /proc/interrupts, then we can add stuffs to it, but I'd rather avoid. =20
Hi, Ben,=20 How about set the host name when calling irq_alloc_host? In the mpic, the host name can be the mpic->name, is it ok? Thanks! Best Regards, Zhang Wei