Re: [parisc-linux] [PATCH 2/2] Make pcibios_add_platform_entries() return errors

On Tue, 2007-03-06 at 12:05 -0600, James Bottomley wrote:

On Tue, 2007-03-06 at 16:06 +0100, Michael Ellerman wrote:

quoted

 int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)

@@ -644,10 +644,13 @@ int __must_check pci_create_sysfs_dev_fi
 		}
 	}
 	/* add platform-specific attributes */
-	pcibios_add_platform_entries(pdev);
+	if (pcibios_add_platform_entries(pdev))
+		goto err_rom_attr;
 
 	return 0;
 
+err_rom_attr:
+	sysfs_remove_bin_file(&pdev->dev.kobj, rom_attr);

This file is only created if the rom resource has a non-zero length.  If
you unconditionally call sysfs_remove_bin_file() it's going to spit
scary warnings and dump traces in this error leg if the rom resource
doesn't exist.

Ah crud, don't write patches during meetings. I'll send a fixed version.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person