RE: [patch 1/1] ppc: Possible bug fix for FCC driver
From: Li Yang-r58472 <hidden>
Date: 2007-03-06 02:22:30
Also in:
lkml
Hi Cedric, For ppc embedded related patches, please also cc: linuxppc-embedded@ozlabs.org.
We use a kernel 2.6.14 on PPC platform (MPC 8555). The FCC driver
works To submit a kernel patch upstream, the patch should be against the latest kernel version which is 2.6.21-rc now.
well with a 100Mbps link. But it doesn't with a 10Mbps link. To solve it, I modified the GFMR register init: removed TCI bit and set CRC32
bit
instead of.
I don't know how these bits caused the 10M link issue. Do you have any reasoning?
Signed-off-by: Cedric Pontois [off-list ref] =20
------------------------------------------------------------------------
quoted hunk
----- =20 diff -ruN pa-original/arch/ppc/8260_io/fcc_enet.c pa-patched/arch/ppc/8260_io/fcc_enet.c--- pa-original/arch/ppc/8260_io/fcc_enet.c 2007-03-0214:57:07.000197000 +0100+++ pa-patched/arch/ppc/8260_io/fcc_enet.c 2007-03-0214:57:08.000038000 +0100@@ -2232,7 +2232,7 @@=20 /* Set GFMR to enable Ethernet operating mode. */ - fccp->fcc_gfmr =3D (FCC_GFMR_TCI | FCC_GFMR_MODE_ENET); + fccp->fcc_gfmr =3D (FCC_GFMR_TCRC_32 | FCC_GFMR_MODE_ENET); =20 /* Set sync/delimiters. */ =20