Thread (10 messages) 10 messages, 2 authors, 2007-04-04

Re: [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup

From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: 2007-02-14 19:42:51
Also in: linux-ide

On Tuesday 13 February 2007 22:43, Sergei Shtylyov wrote:
Fold the now equivalent code in the ide_dma_check() method into a mere call to
ide_use_dma().  Make config_for_dma() return non-zero if DMA mode has been set
and call it from the ide_dma_check() method instead of ide_dma_on().
Also, defer writing the DMA timings to the chip registers until DMA is actually
turned on (and do not enable IORDY for DMA).  Remove unnecessary code from the
init_hwif() method, improve its looks overall, and also rename the driver's
ide_dma_check() and dma_start() methods.

Signed-off-by: Sergei Shtylyov <redacted>

---
The patch has been actually tested at last. :-)
Note that now this driver can be joined to the ide-use-fast-pio patch.
applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help