Re: [PATCH 02/10] powerpc: Add device tree fixups for the EFIKA

Kumar Gala wrote:

On Feb 12, 2007, at 4:13 PM, Sylvain Munaut wrote:

quoted

We make the efika device tree compliant with the defined bindings
(at least compliant enough). This is mostly done by mangling
the device_type and compatible properties, but also adding
some missing bits.

Signed-off-by: Sylvain Munaut <redacted>
Acked-by: Grant Likely <redacted>
---
 arch/powerpc/kernel/prom_init.c |   81
+++++++++++++++++++++++++++++++++++++++
 1 files changed, 81 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kernel/prom_init.c

b/arch/powerpc/kernel/prom_init.c
index 520ef42..4fb5938 100644

--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c

@@ -2117,11 +2117,92 @@ #else
 #define fixup_device_tree_pmac()
 #endif

+#ifdef CONFIG_PPC_EFIKA

can't this EFIKA fixup live in efika board code (platforms/52xx/efika*)

It's too late by then.
Since some of these are needed just to make the board recognized as an
efika and not chrp.
Or for the sram not to be assimilated to normal RAM ...

Some of them probably could by "hacking" the tree after it's been built
I guess that would be possible.
But since some of them are needed in prom_init anyway I think it's
better to keep it grouped there.


    Sylvain