Re: [PATCH] Add base support for the MPC8313E RDB

On Feb 7, 2007, at 6:53 PM, Kim Phillips wrote:

On Wed, 7 Feb 2007 17:36:34 -0600
Kumar Gala [off-list ref] wrote:

quoted

On Feb 7, 2007, at 5:06 PM, Kim Phillips wrote:

quoted

Add support for the MPC8313E Reference Development Board (RDB).
Includes dts.

Can you give some better description about the RDB, like what
functionality it supports, etc..

I'll respin with the details..

thanks

quoted

quoted

+	soc8313@e0000000 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		#interrupt-cells = <2>;
+		device_type = "soc";
+		ranges = <0 e0000000 00100000>;
+		reg = <e0000000 00000200>;
+		bus-frequency = <0>;
+		compatible = "mpc8313\0mpc831x\0mpc83xx";

I'm not sure what this compatible property is suppose to mean?

it was the part of Scott's "ioremap the entire IMMR" patch you  
acked.  I'll take it out for now, since it should really be a part  
of that patch.

Only acked the 'mpc8313, mpc831x' parts, not mpc83xx.

quoted

quoted

+		/* phy type (ULPI, UTMI, UTMI_WIDE, SERIAL) */
+		usb@23000 {
+			device_type = "usb";
+			compatible = "fsl-usb2-dr";
+			reg = <23000 1000>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			interrupt-parent = <700>;
+			interrupts = <26 2>;
+			phy_type = "utmi_wide";

Does anything change because of the integrated UTMI phy?

yes, it's..

quoted

quoted

+			control_init  = <00000280>; // UTMI ext 48 MHz clk

What is 'control_init' ?

..which selects and enables the UTMI phy interface options.

Not documented anywhere, I'd prefer a follow on patch that adds the  
doc details and code that uses it.

quoted

quoted

+
+		ethernet@24000 {
+			device_type = "network";
+			model = "TSEC";

isn't eTSEC on 8313?

quite right, I'll change it.

ok.

- k