Thread (3 messages) 3 messages, 2 authors, 2007-02-28

Re: [PATCH 2/2] ehea: NAPI multi queue TX/RX path for SMP

From: Jan-Bernd Themann <hidden>
Date: 2007-02-28 09:29:32
Also in: lkml, netdev

Hi,
quoted
 
+static inline int ehea_hash_skb(struct sk_buff *skb, int num_qps)
+{
+	u32 tmp;
+	if ((skb->nh.iph->protocol == IPPROTO_TCP)
+	    && skb->protocol == ETH_P_IP) {
skb->protocol has network byte order. The ETH_P_IP test should also
logically come before checking the IP protocol.
fixed.
quoted
+		tmp = (skb->h.th->source + (skb->h.th->dest << 16)) % 31;
Only locally generated packets have a valid h.th pointer.
good point. I'll fix that.

I'll send a new patch set later today

Thanks,
Jan-Bernd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help