Re: [PATCH 1/14] ps3: repository misc fixes

Christoph Hellwig wrote:

On Fri, Jan 26, 2007 at 03:57:41AM +0100, Christoph Hellwig wrote:

quoted

On Wed, Jan 24, 2007 at 06:39:37PM -0800, Geoff Levand wrote:

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_bus_id);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_bus_type);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_bus_num_dev);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_dev_id);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_dev_type);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_dev_intr);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_find_device);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_info);

quoted

+EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_region);

Exporting all these as procedural interfaces is very wrong.  Please
implement a proper bustype for your hypervisor devices where all this
information is an attribute of the hv1_device object.

In addition to that there's no user of these exports in this patch,
so there is no point in adding any kind of export for this type of
information at all yet.  (until we have a proper storage driver)

Both good points.  I'll remove this from the patch and rework it
for later submission.

-Geoff