Thread (3 messages) flat view 3 messages, 2 authors, 2007-01-18

Re: [PATCH 17/19] powerpc: hypervisor console driver for Celleb

From: Ishizaki Kou <hidden>
Date: 2007-01-18 07:53:56

Ben-san,
quoted
+/* temp */
+static int hvc_beat_init(void)
+{
+	struct hvc_struct *hp;
+
+	hp = hvc_alloc(0, NO_IRQ, &hvc_beat_get_put_ops, 16);
+	if (IS_ERR(hp))
+	   return PTR_ERR(hp);
+	   hvc_beat_dev = hp;
+	   return 0;
+}
Please test your are running on beat before initializing your stuff as
your driver might be built as part of a kernel that can boot other
machines. 
I see. I'll fix it by using "firmware_has_feature()" macro.

Best regards,
Kou Ishizaki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help