Re: R_PPC_ADDR16_HI relocs in PPC modules ?

quoted

Ah.  lis and ori.  HI16 is just fine there -- but note that
that doesn't use an add insn.  You're patching the function

lis is an addis with rA=0, don't forget...

Heh true.  "I never forget that" ;-)

quoted

"apply_relocate_add()", so I guess some more work is needed?

Looks fine as it is to me.

Looking at the bigger code, fine with me as well.  Confusing
names are in the nature of this relocation stuff (esp. when
you start adding those ELF-defined "names").


Segher