Thread (4 messages) flat view 4 messages, 2 authors, 2007-01-03

Re: [PATCH] ppc: vio of_node_put cleanup

From: Segher Boessenkool <hidden>
Date: 2007-01-02 13:55:35
Also in: lkml

 static void __devinit vio_dev_release(struct device *dev)
 {
-	if (dev->archdata.of_node) {
-		/* XXX should free TCE table */
-		of_node_put(dev->archdata.of_node);
-	}
+	/* XXX should free TCE table */
+	of_node_put(dev->archdata.of_node);
 	kfree(to_vio_dev(dev));
 }
The comment used to be inside the "if" block, is this
change correct?

[And, do we want all these changes anyway?  I don't care
either way, both sides have their pros and their cons --
just asking :-) ]


Segher
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help