Re: [PATCH 7/19] powerpc: hypervisor call numbers for Celleb

Thank you for your comment.

On Thu, Dec 14, 2006 at 11:30:28AM +0900, Ishizaki Kou wrote:

quoted

+
+#ifdef	__ASSEMBLY__
+#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((__v)<<60|(__x))
+#elif defined(__powerpc64__)
+#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((unsigned long)(__v)<<60|(__x))
+#else
+#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((unsigned long long)(__v)<<60|(__x))
+#endif

__powerpc64__ is always set for ppc64 compiles.

I understand that, but it is shared with our own source code which
runs on 32bit mode.

quoted

+#define HV_allocate_memory (0)
+#define HV_construct_virtual_address_space (2)

isn't HV_foo a little too generic?  Also no need for the braces around
the actual hvall numbers.

It is also shared with our own (proprietary) source code,
so modifying the prefix impacts our software. We think its
impact is small since no files outside of celleb/
will include hvcall number definitions.

Wrapping numbers in braces is problem on our generator,
so we will modify it.

Best regards,
Ishizaki Kou.