Re: [PATCH] powerpc: consolidate mpc83xx platform files

On Dec 15, 2006, at 11:09 AM, Kumar Gala wrote:

quoted

+	if (machine_is(mpc83xx))
+		of_platform_bus_probe(NULL, NULL, NULL);
+

Does this every get called, meaning does anything match machine_is
(mpc83xx)?

I truly dislike this "machine_is" method.  Other architectures
do this and it becomes a real PITA.  It seems to evolve
into something that never has the proper, useful granularity.
Surprisingly, it often ends up as a guarantee you can't boot
common kernels on similar boards, which is what
I suspect you are trying to achieve.

This is a case where your board specific initialization
should call this, or fill in a ppc_md indirect pointer that
if set is called at the proper time.


Thanks.

	-- Dan