Thread (26 messages) 26 messages, 5 authors, 2006-12-26

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

From: Linas Vepstas <hidden>
Date: 2006-12-14 17:15:17
Also in: netdev

On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote:
quoted
 	spider_net_refill_rx_chain(card);
-	spider_net_enable_rxchtails(card);
 	spider_net_enable_rxdmac(card);
 	return 0;
Didn't you just add that line?
Dagnabbit. The earlier pach was moving around existing code.
Or, more precisely, trying to maintain the general function
of the old code even while moving things around.

Later on, when I started looking at what the danged function 
actually did, and the context it was in, I realized that it 
was a bad idea to call the thing.  So then I removed it. :-/

How should I handle this proceedurally? Resend the patch sequence? 
Let it slide?

--linas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help