Thread (8 messages) flat view 8 messages, 3 authors, 2007-01-26

Re: [PATCH/RFC] Change the program check exception from EXC_XFER_STD to EXC_XFER_EE.

From: Paul Mackerras <hidden>
Date: 2006-12-08 04:26:38

Kumar Gala writes:
We don't need to rearrange anything, just put the local_irq_enable()  
call in do_mathemu().  If we are a debugger than REASON_TRAP will  
have to be set and we dont bother with do_mathemu() than.

Do you think we should also move the local_irq_enable() that exists  
in the handler into emulate_instruction().
I'd rather have the local_irq_enable() calls in
program_check_exception() so they're all in one place, preferably with
a comment explaining why they're there.  Having an unpaired
local_irq_enable in do_mathemu() would seem a bit weird to me.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help