Re: [linux-pm] [RFC 1/3] support powermac G5 CPU hotplug
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2006-12-12 13:18:03
Also in:
linux-pm
Attachments
- signature.asc [application/pgp-signature] 190 bytes
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2006-12-12 13:18:03
Also in:
linux-pm
On Tue, 2006-12-12 at 13:09 +0000, Pavel Machek wrote:
quoted
+ /* who knows what context the processor might have died in... */ + task_thread_info(paca[cpu].__current)->preempt_count = 0; +?? Context for downing cpu should better be well-defined. Just do this in cpu_die if it is really required.
It is actually required but I'm not exactly sure why. When I don't do this, I end up with preempt_count() 0x100000 (IIRC, notes not here at the moment). I think this is because the suspend code has interrupts disabled already when downing the CPUs. johannes