Thread (19 messages) 19 messages, 6 authors, 2006-11-06

Re: [PATCH/RFC] powerpc: Add MPC5200 Interrupt Controller support.

flat view

From: Nicolas DET <hidden>
Date: 2006-11-02 20:47:49

Nicolas DET wrote:
Benjamin Herrenschmidt wrote:
quoted
Now, in addition to that, we have another issue I haven't spotted
before, but it might be worth considering:

Do we actually want the sdma interrupts handled there ? Because if you
look closely, the SDMA is basically a cascaded interrupt controller. It
hangs of per interrupt 0 :)
I know. I already spot this point (IRQ as far as I remenber and in private mails) and I got no answer so I assumed it was ok like I did. It's also really simplier and easier to add SDMA has another irq_chip.
Keep is simple ;-)
quoted
Thus we could simply remove the code for it from that driver and
implement it as as separate controller with a separate interrupt domain.
I know you won't like that idea because it means having a different
interrupt tree but it's worth having the discussion.
The device tree won't change anyway...

I'll submit a new buch of patches pretty soon. Maybe the final version.

"On y est presque !" ;-)
I attached the new Interrupt Controller patch. I have been very busy today. I hope I did not overlook anything.

RFC

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help