Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
flat view
From: Arnd Bergmann <arnd@arndb.de>
Date: 2006-11-05 23:46:07
Also in:
lkml
On Sunday 05 November 2006 21:40, Hoang-Nam Nguyen wrote:
quoted hunk ↗ jump to hunk
+/* constructor ctblk_cache */ +void ehca_ctblk_ctor(void *ptr, kmem_cache_t *cache, unsigned long flags) +{ + memset(ptr, 0, EHCA_PAGESIZE); +} + +void *ehca_alloc_fw_ctrlblock(void) +{ + void *ret =3D kmem_cache_alloc(ctblk_cache, SLAB_KERNEL); + if (!ret) + =A0ehca_gen_err("Out of memory for ctblk"); + return ret; +} + +void ehca_free_fw_ctrlblock(void *ptr) +{ + if (ptr) + =A0kmem_cache_free(ctblk_cache, ptr); +
This seems broken. You have a constructor for newly allocated objects, but there is no destructor and it seems that objects passed to ehca_free_fw_ctrlblock are not guaranteed to be initialized either. I'd simply move the memset into the alloc function and get rid of the constructor here. Arnd <><