On Tue, 31 Oct 2006 15:22:13 +0100 Christoph Hellwig [off-list ref] wrote:

 - vicocons.c can't be compiled at the same time as CONFIG_VT, but
   instead of expressing that in the Kconfig it errors out in that
   case.  This should at least be a Kconfig dependency, but long
   term viocons must work at the same time as the normal vt code
   to have a single ppc64 image

viocons is deprecated (in favour of hvc_iseries) so we just need Kconfig
to say to build it only CONFIG_VT is not defined.

 - vioscsi linkage fails because iseries_vscsi.c and rpa_vscsi.c.
   This needs some trivial indirection via function vectors, but
   how can we find out which one to use from the driver?  Both
   seem to look the same in the device tree

The maintainer suggested that we just don't build vioscsi for iseries
if we are building the rpa version as it is not often used (in particular,
it is not used for installations).  We could, however distinguish them
by changing the "compat" field in the iSeries device tree if we wished.

 - arch/powerpc/platforms/iseries/setup.c references rd_size
   when CONFIG_INITRD is set.  But rd_size is defined drivers/block/rd.c
   which can me modular (and is selected by CONFIG_BLK_DEV_RAM).
   This same bug is repeated in the arm amd arm26 code, but except
   for those no one outside of rd.c uses this symbol.  I don't see
   a point why arch code should modify this as it's already big enough.

A fix for this has already been posted
(http://patchwork.ozlabs.org/linuxppc/patch?id=7523).

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/