Re: [PATCH] Make irq_dispose_mapping(NO_IRQ) a nop
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-10-24 03:52:28
On Tue, 2006-10-24 at 13:37 +1000, Michael Ellerman wrote:
It makes for a friendlier API if irq_dispose_mapping(NO_IRQ) is a nop, rather than triggering a WARN_ON. Signed-off-by: Michael Ellerman <redacted>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
quoted hunk ↗ jump to hunk
--- arch/powerpc/kernel/irq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Index: git/arch/powerpc/kernel/irq.c ===================================================================--- git.orig/arch/powerpc/kernel/irq.c +++ git/arch/powerpc/kernel/irq.c@@ -626,10 +626,14 @@ EXPORT_SYMBOL_GPL(irq_of_parse_and_map); void irq_dispose_mapping(unsigned int virq) { - struct irq_host *host = irq_map[virq].host; + struct irq_host *host; irq_hw_number_t hwirq; unsigned long flags; + if (virq == NO_IRQ) + return; + + host = irq_map[virq].host; WARN_ON (host == NULL); if (host == NULL) return;