-----Original Message-----
From: Vitaly Bordug [mailto:vbordug@ru.mvista.com]
Sent: Wednesday, September 27, 2006 7:56 PM
To: Paul Mackerras
Cc: Li Yang-r58472; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 10/11] Add MPC8360EMDS board support
=20
On Wed, 27 Sep 2006 16:39:11 +1000
Paul Mackerras [off-list ref] wrote:
=20

quoted

Li Yang writes:

quoted

+#define BCSR_PHYS_ADDR		((uint)0xf8000000)
+#define BCSR_SIZE		((uint)(32 * 1024))

This sort of thing should really be in the device tree.

Just a suggestion, but for the similar aim in pq2 I have those stuff

in memory node :

=20
+memory {
+               device_type =3D "memory";
+               linux,phandle =3D <300>;
+               reg =3D <00000000 4000000 f4500000 00000020>;
+       };
the second pair is about bcsr and its size.
=20
Just in case this may help (and wondering if I'm not violating

something :) )

Well, this can make it work.  But I would prefer to use a new node
because the BCSR is by no means a memory type of device.  I have made my
change to use node like this:

        bcsr@f8000000 {
                device_type =3D "board-control";
                reg =3D <f8000000 8000>;
        };

- Leo