RE: [RFC][PATCH] QE device tree node definition
From: Li Tony-r64360 <hidden>
Date: 2006-09-26 09:57:47
=20
-----Original Message----- From: Li Yang-r58472=20 Sent: Tuesday, September 26, 2006 2:24 PM To: Li Tony-r64360; linuxppc-dev@ozlabs.org Subject: RE: [RFC][PATCH] QE device tree node definition =20quoted
-----Original Message----- From: linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org =20[mailto:linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org]=20 On Behalf=20quoted
Of Li Tony-r64360 Sent: Tuesday, September 26, 2006 10:40 AM To: linuxppc-dev@ozlabs.org Subject: RE: [RFC][PATCH] QE device tree node definition =20 =20 1) Where is the QE embedded interrupt controller ? I think the interrupt-parent of the QE function should point to it.=20 QEIC is not necessarily to be defined specifically rather=20 than using generic interrupt controller spec.quoted
=20 2) For the UCC, It is better to make rx-clock and tx-clock=20as required=20quoted
properties. Almost all functions need this properties=20 Almost is NOT enough to make them required properties for all=20 UCC functions. There are some devices uses TSA as clock source.
If using TSA, the xx-clock property can use some specific macro to represent it. All the UCC need a general clock whether from clocks or TSA.=20
=20 - Leo =20