RE: [PATCH 4/11] qe_lib: Add QE I/O ports API

Hi Leo

As you know I working with your earlier patches, trying to adopt them
for
8321. Everthing works but ethernet on UCC2 and UCC4, ethernet on UCC3
works though.

Anyhow I found some minor changes I had to do to match 8321 that is
generic 83xx code.
Below is the first:

---
 arch/powerpc/sysdev/qe_lib/qe_io.c |  272=20
+#define NUM_OF_PAR_IOS  7

NUM_OF_PAR_IOS is 4 on 8321

+static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] =3D {
+	/* 0-7 */          /* 8-15 */      /* 16 - 23 */     /*=20
24 - 31 */
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0,=20
0,0,0,0,0,1,1,0},
+	{0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,=20
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,=20
0,0,0,1,1,1,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0,=20
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,=20
1,1,1,1,0,0,0,1},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0,=20
0,0,0,0,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,=20
0,0,0,0,0,0,0,1}
+};

qe_irq_ports is diffrent on 8321 not only the number of rows.

These needs to configuruable based on CPU model and/or type of board.

 Jocke

On Thu, 21 Sep 2006 16:52:14 +0200
"Joakim Tjernlund" [off-list ref] wrote:

Hi Leo

As you know I working with your earlier patches, trying to adopt them
for
8321. Everthing works but ethernet on UCC2 and UCC4, ethernet on UCC3
works though.

Anyhow I found some minor changes I had to do to match 8321 that is
generic 83xx code.
Below is the first:

quoted

---
 arch/powerpc/sysdev/qe_lib/qe_io.c |  272 
+#define NUM_OF_PAR_IOS  7

NUM_OF_PAR_IOS is 4 on 8321

quoted

+static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] = {
+	/* 0-7 */          /* 8-15 */      /* 16 - 23 */     /* 
24 - 31 */
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0, 
0,0,0,0,0,1,1,0},
+	{0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0, 
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 
0,0,0,1,1,1,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0, 
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0, 
1,1,1,1,0,0,0,1},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0, 
0,0,0,0,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 
0,0,0,0,0,0,0,1}
+};

qe_irq_ports is diffrent on 8321 not only the number of rows.

These needs to configuruable based on CPU model and/or type of board.

Well, eventually this stuff aims to serve not 83xx/qe, but for cpm(1,2)-equipped stuff
too. Apparently, we'll have to do something wise to afford that...

OTOH, this is good as a starting point I guess.

-- 
Sincerely, 
Vitaly

quoted

+static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] = {
+	/* 0-7 */          /* 8-15 */      /* 16 - 23 */     /*
24 - 31 */
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0,
0,0,0,0,0,1,1,0},
+	{0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
0,0,0,1,1,1,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0,
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
1,1,1,1,0,0,0,1},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0,
0,0,0,0,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
0,0,0,0,0,0,0,1}
+};

qe_irq_ports is diffrent on 8321 not only the number of rows.

These needs to configuruable based on CPU model and/or type of board.

That sounds like a job for the DTS

Well, eventually this stuff aims to serve not 83xx/qe, but for cpm(1,2)-equipped stuff
too. Apparently, we'll have to do something wise to afford that...

OTOH, this is good as a starting point I guess.

This is typical of stuff that should be in the device-tree

Ben.

-----Original Message-----
From: Vitaly Bordug [mailto:vbordug@ru.mvista.com]
Sent: Thursday, September 21, 2006 11:22 PM
To: Joakim Tjernlund
Cc: Li Yang-r58472; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/11] qe_lib: Add QE I/O ports API
=20
On Thu, 21 Sep 2006 16:52:14 +0200
"Joakim Tjernlund" [off-list ref] wrote:
=20

quoted

Hi Leo

As you know I working with your earlier patches, trying to adopt

them

quoted

for
8321. Everthing works but ethernet on UCC2 and UCC4, ethernet on

UCC3

quoted

works though.

Anyhow I found some minor changes I had to do to match 8321 that is
generic 83xx code.
Below is the first:

quoted

---
 arch/powerpc/sysdev/qe_lib/qe_io.c |  272
+#define NUM_OF_PAR_IOS  7

NUM_OF_PAR_IOS is 4 on 8321

quoted

+static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] =3D {
+	/* 0-7 */          /* 8-15 */      /* 16 - 23 */     /*
24 - 31 */
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0,
0,0,0,0,0,1,1,0},
+	{0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
0,0,0,1,1,1,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0,
0,0,1,1,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
1,1,1,1,0,0,0,1},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0,
0,0,0,0,0,0,0,0},
+	{0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
0,0,0,0,0,0,0,1}
+};

qe_irq_ports is diffrent on 8321 not only the number of rows.

These needs to configuruable based on CPU model and/or type of

board.

quoted

=20
Well, eventually this stuff aims to serve not 83xx/qe, but for

cpm(1,2)-equipped

stuff
too. Apparently, we'll have to do something wise to afford that...
=20
OTOH, this is good as a starting point I guess.

I agree.  I will remove the I/O port interrupt stuff for now.  Anyway,
it is not used by any code in kernel for now.

- Leo