Thread (18 messages) 18 messages, 5 authors, 2006-09-28

Re: common flatdevtree code

From: Mark A. Greer <hidden>
Date: 2006-09-07 18:27:17

Hi Hollis.

On Thu, Sep 07, 2006 at 02:43:31AM -0500, Hollis Blanchard wrote:
Thanks Mark!

On Wed, 2006-09-06 at 17:36 -0700, Mark A. Greer wrote:
quoted
void *ft_find_device(const void *bphp, const char *srch_path)
How about "ft_find_node"?
Sure.
I renamed that and made a couple other small
changes. In particular:
- u8->int
OK.
- exit and free -> ft_exit and ft_free (so they can be wrapped in
flatdevtree_env.h)
Makes sense.
- moved those inlines out of flatdevtree.h, since they don't need to be
exported
ft_parentize is also used in flatdevtree_misc.c so I think they
should stay in flatdevtree.h.
I just put up a Mercurial tree. I didn't include your flatdevtree_misc.c
since it's kernel-specific, and I added a userspace flatdevtree_env.h.

To get the source:
hg clone http://unsanctioned.org/flatdevtree/hgweb.py flatdevtree
Oh, cool.
I'd like to add some unit tests in the near future (e.g. comparing with
dtc output), but I wasted a couple hours screwing with a makefile
instead. :(

By the way, could you send a patch adding your copyright info?
Yeah, I'm still cleaning up & testing a bit.  I should have them out
today unless something comes up (well in addition to a scheduled hour
long network outtage :( .

Mark
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help