Re: [PATCH] fix for firewire patch added in 2.6.17.2 that breaks things on ppc

On Tue, Aug 08, 2006 at 03:05:15PM +1000, Paul Mackerras wrote:

danny@mailmij.org writes:

quoted

-#endif
-
+#else
 	pci_save_state(pdev);
-
+#endif /* CONFIG_PPC_PMAC */

Shouldn't we just move the pci_save_state call up before the
pmac_call_feature() call?

Paul.

I tested this. It works, but it has no effect (pci_restore_state does not report that anything changed,
thus this means that the config space already contained the correct values).

I discovered one additional problem with leaving a device running through a sleep/resume cycle:
suspend:
ohci1394: fw-host0: SelfID received outside of bus reset sequence
resume:
ohci1394: fw-host0: SelfID is inconsistent [0x7e80773f/0x7e80773f]
The last leads to the node not being able to resume when the device is actually plugged.

Anyway, it's a separate issue, I will investigate.

Danny