Re: [RFC] asm code for Hypervisor Call Instrumentation

On Wed, Aug 02, 2006 at 09:05:06PM -0700, Mike Kravetz wrote:

On Thu, Aug 03, 2006 at 01:57:17PM +1000, Stephen Rothwell wrote:

quoted

On Wed, 2 Aug 2006 10:59:47 -0700 Mike Kravetz [off-list ref] wrote:

quoted

+#else
+
+#define STACKFRAMESIZE	0
+#define HCALL_INST_PRECALL	nop
+#define HCALL_INST_POSTCALL	nop

Why even "nop", why not just blank?

At first I was concerned about macro expansion and knew a 'nop'
would be ok.  Intended to go back and try 'blank', but forgot.
I'll give it a try.

What is the preferred method to 'leave it blank'?

#define HCALL_INST_PRECALL	/* nop */
#define HCALL_INST_PRECALL	;
something else?

Leaving HCALL_INST_PRECALL undefined results in an assembler error.

-- 
Mike