Re: [PATCH] Add MPC8641 HPCN Device Tree Source file.

On Aug 2, 2006, at 3:36 PM, Jon Loeliger wrote:

On Wed, 2006-08-02 at 15:30, Kumar Gala wrote:

quoted

quoted

Yeah, we have lined up Matt to make a comprehensive
update for this.  Can we take my patch as-is?  Matt will
follow up with a clean sweep, including fsl_socl.c, to
fix it all in one swell foop.

I think this is one that is clearly something that should be fixed
before acceptance.  Since we are talking about a dozen lines of
modifications.  Especially since at this point having the .dts in the
tree doesn't really effect anything inside the kernel tree.

- kumar

On the other hand, this matches what the kernel implements
today, and is already in use by several people around the
world.  It _does_ have an affect and is based on things
inside the kernel tree today as it is.

True, but the people that are running this dont really care if the  
dts is in the kernel or not. I think having an error in the kernel  
tree that we know about is more of an issue.  Its something we all  
agree needs to be fixed.

Here is the code modification to fsl_soc.c, I'm sure we can get this  
fixed push into 2.6.18 if desired.

if(mac_addr = get_property(np, "address", NULL))
   memcpy(gfar_data.mac_addr, mac_addr, 6);

if(mac_addr = get_property(np, "local-mac-address", NULL);
   memcpy(gfar_data.mac_addr, mac_addr, 6);

- kumar