Re: [PATCH 2/4]: powerpc/cell spidernet low watermark patch.
From: David Miller <davem@davemloft.net>
Date: 2006-08-22 00:30:04
Also in:
lkml, netdev
From: linas@austin.ibm.com (Linas Vepstas) Date: Mon, 21 Aug 2006 19:13:11 -0500
quoted hunk ↗ jump to hunk
@@ -1495,16 +1500,16 @@ spider_net_interrupt(int irq, void *ptr, if (!status_reg) return IRQ_NONE; - if (status_reg & SPIDER_NET_RXINT ) { + if (status_reg & SPIDER_NET_RXINT) { spider_net_rx_irq_off(card); netif_rx_schedule(netdev); } - if (status_reg & SPIDER_NET_TXINT ) { - spider_net_cleanup_tx_ring(card); - netif_wake_queue(netdev); - } - if (status_reg & SPIDER_NET_ERRINT ) + /* Call rx_schedule from the tx interrupt, so that NAPI poll runs. */ + if (status_reg & SPIDER_NET_TXINT) + netif_rx_schedule(netdev); + + if (status_reg & SPIDER_NET_ERRINT)
This should be:
if ((status_reg & (SPIDET_NET_RXINT | SPIDET_NET_TXINT))) {
spider_net_rx_and_tx_irq_off(card);
netif_rx_schedule();
}